[ 
https://issues.apache.org/jira/browse/TS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125315#comment-13125315
 ] 

Leif Hedstrom commented on TS-917:
----------------------------------

Manjesh: I took a look at this, and I don't quite see it. First, I tried it by 
reloading the remap.config lots of times, and I see no indications of memory 
being leaked. "ps" and "valgrind" both says there's no leak.

Secondly, looking at the code, it looks like it should free it, e.g.

{code}
  forl_LL(T, iter, m_value_list)
    delete iter;
  m_value_list.clear();
{code}

If I'm not mistaken, this invokes the destructor for the url_mapping. Or are 
there other places where this is missing? Perhaps something with URL regexes 
(which I didn't test)?
                
> url_mapping objects don't seem to be deleted
> --------------------------------------------
>
>                 Key: TS-917
>                 URL: https://issues.apache.org/jira/browse/TS-917
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Remap API
>    Affects Versions: 3.0.0
>            Reporter: Manjesh Nilange
>            Assignee: Leif Hedstrom
>             Fix For: 3.1.1
>
>
> In the recent changes to data structures in 
> UrlRewrite/UrlMappingPathIndex/UrlMappingContainer classes, the url_mapping 
> itself is not deleted, I think. The PathIndex, Trie objects are cleaned up, 
> but not the url_mapping.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to