[
https://issues.apache.org/jira/browse/TS-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125346#comment-13125346
]
Manjesh Nilange commented on TS-917:
------------------------------------
Leif, I think you are right. I don't think there is a leak. I was not sure if
url_mapping objects were deleted, but I did not see this change -
http://svn.apache.org/viewvc/trafficserver/traffic/trunk/proxy/http/remap/Trie.h?diff_format=l&r1=1085816&r2=1085815&pathrev=1085816.
It's not intuitive or clean as it is UrlRewrite.cc/url_rewrite class that does
the new() and the Trie class does the delete. I don't think the Trie is being
used anywhere else, but the user would have to know that the Trie will
automatically delete the objects it holds even though it does not create them.
As for the RegexMapping, I didn't get what you are saying. The delete line does
delete the url_mapping object and then the RegexMapping object itself is
deleted later in the code. So both objects are cleaned up.
> url_mapping objects don't seem to be deleted
> --------------------------------------------
>
> Key: TS-917
> URL: https://issues.apache.org/jira/browse/TS-917
> Project: Traffic Server
> Issue Type: Bug
> Components: Remap API
> Affects Versions: 3.0.0
> Reporter: Manjesh Nilange
> Assignee: Leif Hedstrom
> Fix For: 3.1.1
>
>
> In the recent changes to data structures in
> UrlRewrite/UrlMappingPathIndex/UrlMappingContainer classes, the url_mapping
> itself is not deleted, I think. The PathIndex, Trie objects are cleaned up,
> but not the url_mapping.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
