[
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214882#comment-13214882
]
Leif Hedstrom commented on TS-1102:
-----------------------------------
Did you patch fix --disable-diags ? If not, I can do that.
I tested the patch, looks good. I redid my benchmark a bit, to make sure I
measure things properly. Here's the result from current trunk:
{code}
163184902 fetches on 163211 conns, 390 max parallel, 1.631849E+08 bytes, in 900
seconds
1 mean bytes/fetch
181316.5 fetches/sec, 1.813165E+05 bytes/sec
msecs/connect: 0.283 mean, 6.224 max, 0.045 min
msecs/first-response: 1.520 mean, 500.103 max, 0.077 min
{code}
This is with your latest patch:
{code}
http_load -parallel 130 -seconds 900 -keep_alive 1000 /tmp/TINY
166093081 fetches on 166107 conns, 390 max parallel, 1.660930E+08 bytes, in 900
seconds
1 mean bytes/fetch
184547.8 fetches/sec, 1.845478E+05 bytes/sec
msecs/connect: 0.425 mean, 341.253 max, 0.042 min
msecs/first-response: 1.460 mean, 290.295 max, 0.075 min
{code}
So, looks good to me. Let me check with pre-1102 as well, but I think this
looks promising.
> Cleanup obsolete debugging code
> -------------------------------
>
> Key: TS-1102
> URL: https://issues.apache.org/jira/browse/TS-1102
> Project: Traffic Server
> Issue Type: Bug
> Components: Core, Logging, Performance
> Affects Versions: 3.0.2
> Environment: Any
> Reporter: Uri Shachar
> Assignee: Leif Hedstrom
> Priority: Minor
> Fix For: 3.1.3
>
> Attachments: ats.benchmark, diags_cleanup.patch,
> diags_perf_and_remove_debugon.patch, diags_remove_debugon.patch,
> remove_prefix_arg.patch, remove_prefix_arg_v2.patch,
> remove_prefix_arg_v3.patch
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1
> for all compilation environments, and it includes variadic argument macro
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are
> provided.
> Removing the added layer should also improve performance when high volume
> debugging is turned on.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
