[ 
https://issues.apache.org/jira/browse/TS-1102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13216015#comment-13216015
 ] 

Leif Hedstrom commented on TS-1102:
-----------------------------------

Uri, should we try to fix --disable-diags too? And with we, I mean you ;).

I committed everything else, thanks for the fixes.
                
> Cleanup obsolete debugging code
> -------------------------------
>
>                 Key: TS-1102
>                 URL: https://issues.apache.org/jira/browse/TS-1102
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Core, Logging, Performance
>    Affects Versions: 3.0.2
>         Environment: Any
>            Reporter: Uri Shachar
>            Assignee: Leif Hedstrom
>            Priority: Minor
>             Fix For: 3.1.3
>
>         Attachments: ats.benchmark, diags_cleanup.patch, 
> diags_perf_and_remove_debugon.patch, diags_remove_debugon.patch, 
> remove_prefix_arg.patch, remove_prefix_arg_v2.patch, 
> remove_prefix_arg_v3.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> The current Diags.h D/EClosure mechanism is obsolete. ATS requires gcc >= 4.1 
> for all compilation environments, and it includes variadic argument macro 
> support with ##_VA_ARGS_ that deletes the final comma if no arguments are 
> provided.
> Removing the added layer should also improve performance when high volume 
> debugging is turned on.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to