[ 
https://issues.apache.org/jira/browse/TS-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697207#comment-14697207
 ] 

Sudheer Vinukonda commented on TS-3777:
---------------------------------------

A couple of comments:

1. I think resetting pipeline_possible on VC_EVENT_EOS may result in issues - 
my understanding of the current version of the code (without any of the patches 
from this jira) is that an EOS marks it explicitly to just half close (only, 
the READ side), to allow for any data read from the server tunnel to be sent to 
the client - the comments around this code indicate as much as well. Marking 
pipeline_possible to false could break that.

{code}
  switch (event) {
  /* EOS means that the client has initiated the connection shut down.
   * Only half close the client connection so ATS can read additional
   * data that may still be sent from the server and send it to the
   * client.
   */
  case VC_EVENT_EOS:
    static_cast<HttpClientSession 
*>(ua_entry->vc)->get_netvc()->do_io_shutdown(IO_SHUTDOWN_READ);
    break;

{code}

2. I doubt if the patch here will fix TS-3584, unless I'm missing something - 
SPDY/H2 are explicitly marked as non-internal requests, so, they should 
continue to remain keep_alive by default?

IMO, the safest solution for this issue is to limit it to turning off 
keep_alive and pipeline_possible flags for requests marked internal.

> TSHttpConnect and POST request does not fire TS_VCONN_READ_COMPLETE nor 
> TS_VCONN_EOS
> ------------------------------------------------------------------------------------
>
>                 Key: TS-3777
>                 URL: https://issues.apache.org/jira/browse/TS-3777
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: TS API
>            Reporter: Daniel Vitor Morilha
>            Assignee: Susan Hinrichs
>              Labels: yahoo
>             Fix For: 6.1.0
>
>         Attachments: ts-3777-2.diff, ts-3777-3.diff, ts-3777.diff
>
>
> When using TSHttpConnect to connect to ATS itself (internal vconnection), 
> sending a POST request and receiving a CHUNKED response. ATS does not fire 
> neither TS_VCONN_READ_COMPLETE nor TS_VCONN_EOS.
> Trying to close the vconnection from the plug-in after receiving the last 
> chunk ("\r\n0\r\n") results into the PluginVC repeating the following message:
> {noformat}
> [Jul 14 21:24:06.094] Server {0x7ffff7fbe800} DEBUG: (pvc_event) [0] Passive: 
> Received event 1
> {noformat}
> I am glad to provide an example if that helps.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to