[
https://issues.apache.org/jira/browse/TS-3478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15066002#comment-15066002
]
ASF GitHub Bot commented on TS-3478:
------------------------------------
Github user masaori335 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/391#discussion_r48113520
--- Diff: proxy/http2/HPACK.h ---
@@ -153,9 +165,9 @@ int64_t decode_string(Arena &arena, char **str,
uint32_t &str_length, const uint
int64_t encode_indexed_header_field(uint8_t *buf_start, const uint8_t
*buf_end, uint32_t index);
int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t
*buf_end, const MIMEFieldWrapper &header, uint32_t index,
- HpackFieldType type);
+ Http2DynamicTable &dynamic_table,
HpackFieldType type);
int64_t encode_literal_header_field(uint8_t *buf_start, const uint8_t
*buf_end, const MIMEFieldWrapper &header,
--- End diff --
Those `encode_literal_header_field()` should be something like
`encode_literal_header_field_with_indexed_name()` and
`encode_literal_header_field_with_new_name()` ?
> Indexing header representations on HPACK encoder
> ------------------------------------------------
>
> Key: TS-3478
> URL: https://issues.apache.org/jira/browse/TS-3478
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Ryo Okubo
> Assignee: Ryo Okubo
> Labels: review
> Fix For: 6.1.0
>
> Attachments: indexing.patch
>
>
> Support other header field representations on HPACK encoder.
> http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6
> Currently the encoder supports only [Literal Header Field never
> Indexed|http://tools.ietf.org/html/draft-ietf-httpbis-header-compression-12#section-6.2.3].
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
