[ 
https://issues.apache.org/jira/browse/TS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15256959#comment-15256959
 ] 

ASF GitHub Bot commented on TS-4328:
------------------------------------

Github user zwoop commented on the pull request:

    https://github.com/apache/trafficserver/pull/554#issuecomment-214505724
  
    It's unfortunate because it couple internal state in the SM to the 
milestones, which are timing events. This means, changes to the milestones 
could have bad effects on other code, which would be really tricky to debug. 
It's sort of a violation of encapsulation, or even depending on side effects as 
a feature.


> Connect_retries re-connects even if request made it to origin (TS-3440 repeat)
> ------------------------------------------------------------------------------
>
>                 Key: TS-4328
>                 URL: https://issues.apache.org/jira/browse/TS-4328
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Thomas Jackson
>            Assignee: Thomas Jackson
>             Fix For: sometime
>
>
> I'm creating another issue as the root bug for TS-3440 can still be 
> reproduced if the origin is extremely slow (but no returns no error response).
> I've opened a PR (https://github.com/apache/trafficserver/pull/554) which 
> reverts the original patch and instead checks if any bytes where sent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to