[ 
https://issues.apache.org/jira/browse/TS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15299039#comment-15299039
 ] 

ASF subversion and git services commented on TS-4328:
-----------------------------------------------------

Commit 736009b973ad44ef4c7185f5f3bfb778903e4316 in trafficserver's branch 
refs/heads/master from [~jacksontj]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=736009b ]

TS-3959: requests are retryable only if bytes were sent and there was no 
connection error

The root issue that TS-4328 and TS-3440 were trying to fix was that ATS was too 
aggressive in retries to origin (namely after the origin had already recieved 
the request). The previous patches attempted to have ATS not retry assuming 
bytes were sent on the wire-- sadly TS-4328 actually only checks that we set 
bytes to be written to the wire. To fix this we simply check if there was a 
connection failure to origin, if so we'll assume that it is retryable (since 
connection failures to origin should only be due to errors writing/connecting 
etc.).


> Connect_retries re-connects even if request made it to origin (TS-3440 repeat)
> ------------------------------------------------------------------------------
>
>                 Key: TS-4328
>                 URL: https://issues.apache.org/jira/browse/TS-4328
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Thomas Jackson
>            Assignee: Thomas Jackson
>             Fix For: 6.2.0
>
>
> I'm creating another issue as the root bug for TS-3440 can still be 
> reproduced if the origin is extremely slow (but no returns no error response).
> I've opened a PR (https://github.com/apache/trafficserver/pull/554) which 
> reverts the original patch and instead checks if any bytes where sent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to