[ https://issues.apache.org/jira/browse/TS-4399?focusedWorklogId=30093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30093 ]
ASF GitHub Bot logged work on TS-4399: -------------------------------------- Author: ASF GitHub Bot Created on: 03/Oct/16 20:18 Start Date: 03/Oct/16 20:18 Worklog Time Spent: 10m Work Description: GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1073 TS-4399 TS-4400 Management API messes up proxy options TS-4399: Management API breaks diagnostic log rotation TS-4400: TSProxyStateSet persist cache clearing across restart The two issues are related in that they both deal with the management API not correctly handling proxy flags. For TS-4399, it was because the management API was not aware of traffic_manager setting extra proxy options. This was fixed by providing CoreAPI a callback to get extra proxy options from traffic_manager. For TS-4400, it was because the management API was not properly clearing optional flags between proxy reboots. This was fixed by resetting the proxy options before each reboot. You can merge this pull request into a Git repository by running: $ git pull https://github.com/danobi/trafficserver TS-4399_TS-4400 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/1073.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1073 ---- commit 9f28180ae4bebfb529a8a7f3bf6758cb44a3c57a Author: Daniel Xu <dl...@yahoo.com> Date: 2016-10-03T19:05:57Z TS-4399 TS-4400 Management API messes up proxy options TS-4399: Management API breaks diagnostic log rotation TS-4400: TSProxyStateSet persist cache clearing across restart The two issues are related in that they both deal with the management API not correctly handling proxy flags. For TS-4399, it was because the management API was not aware of traffic_manager setting extra proxy options. This was fixed by providing CoreAPI a callback to get extra proxy options from traffic_manager. For TS-4400, it was because the management API was not properly clearing optional flags between proxy reboots. This was fixed by resetting the proxy options before each reboot. commit 3365b2048e7bf0660faccf573ffd198857d03d25 Author: Daniel Xu <dl...@yahoo.com> Date: 2016-10-03T20:14:24Z Fix memory leaks ---- Issue Time Tracking ------------------- Worklog Id: (was: 30093) Time Spent: 10m Remaining Estimate: 0h > Management API breaks diagnostic log rotation > --------------------------------------------- > > Key: TS-4399 > URL: https://issues.apache.org/jira/browse/TS-4399 > Project: Traffic Server > Issue Type: Bug > Components: Logging, Management API > Reporter: James Peach > Assignee: Daniel Xu > Fix For: 7.1.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Start up Traffic Server: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.02 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26952 26951 0 10:13AM ?? 0:00.08 /opt/ats/bin/traffic_server > -M --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out --httpport 8080:fd=12 > {code} > Now restart it using {{traffic_line -S}} followed by {{traffic_line -U}}: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.05 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26967 26951 0 10:13AM ?? 0:00.12 /opt/ats/bin/traffic_server > -M --httpport 8080:fd=20 > {code} > Note that we lost the {{\--bind_stdout}} and {{\--bind_stderr}} options. -- This message was sent by Atlassian JIRA (v6.3.4#6332)