[ https://issues.apache.org/jira/browse/TS-4399?focusedWorklogId=30900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30900 ]
ASF GitHub Bot logged work on TS-4399: -------------------------------------- Author: ASF GitHub Bot Created on: 20/Oct/16 03:47 Start Date: 20/Oct/16 03:47 Worklog Time Spent: 10m Work Description: Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1073#discussion_r84208189 --- Diff: cmd/traffic_manager/traffic_manager.cc --- @@ -611,31 +614,35 @@ main(int argc, const char **argv) /* Update cmd line overrides/environmental overrides/etc */ if (tsArgs) { /* Passed command line args for proxy */ + char* new_proxy_opts = new char[strlen(lmgmt->proxy_options) + strlen(tsArgs) + 1]; + strcpy(new_proxy_opts, lmgmt->proxy_options); + strcat(new_proxy_opts, tsArgs); ats_free(lmgmt->proxy_options); - lmgmt->proxy_options = tsArgs; - mgmt_log("[main] Traffic Server Args: '%s'\n", lmgmt->proxy_options); + lmgmt->proxy_options = new_proxy_opts; --- End diff -- At this point ``lmgmt->proxy_options`` isn't set, so just copy ``tsArgs`` into the text buffer if it is present. Issue Time Tracking ------------------- Worklog Id: (was: 30900) Time Spent: 1h (was: 50m) > Management API breaks diagnostic log rotation > --------------------------------------------- > > Key: TS-4399 > URL: https://issues.apache.org/jira/browse/TS-4399 > Project: Traffic Server > Issue Type: Bug > Components: Logging, Management API > Reporter: James Peach > Assignee: Daniel Xu > Fix For: 7.1.0 > > Time Spent: 1h > Remaining Estimate: 0h > > Start up Traffic Server: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.02 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26952 26951 0 10:13AM ?? 0:00.08 /opt/ats/bin/traffic_server > -M --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out --httpport 8080:fd=12 > {code} > Now restart it using {{traffic_line -S}} followed by {{traffic_line -U}}: > {code} > 0 26950 1 0 10:13AM ?? 0:00.01 /opt/ats/bin/traffic_cop > -2 26951 26950 0 10:13AM ?? 0:00.05 /opt/ats/bin/traffic_manager > --bind_stdout /opt/ats/var/log/trafficserver/traffic.out --bind_stderr > /opt/ats/var/log/trafficserver/traffic.out > -2 26967 26951 0 10:13AM ?? 0:00.12 /opt/ats/bin/traffic_server > -M --httpport 8080:fd=20 > {code} > Note that we lost the {{\--bind_stdout}} and {{\--bind_stderr}} options. -- This message was sent by Atlassian JIRA (v6.3.4#6332)