[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30385&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30385
]
ASF GitHub Bot logged work on TS-4948:
--------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/16 17:59
Start Date: 11/Oct/16 17:59
Worklog Time Spent: 10m
Work Description: GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1092
TS-4948: Adjust code to prevent NULL variable reference.
Attempting to fix a coverity warning by clearing the user_client_addr bool
when the client_addr variable cannot be reset from NULL. The later references
to uses of client_addr are covered by the use_client_addr bool.
Cannot directly run coverity, so not sure this makes the tool happy.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4948
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/1092.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1092
----
commit b04ecf7440e53764bbf0f161a9c3ec187e7cf81f
Author: Susan Hinrichs <[email protected]>
Date: 2016-10-11T17:56:42Z
TS-4948: Adjust code to prevent NULL variable reference.
----
Issue Time Tracking
-------------------
Worklog Id: (was: 30385)
Time Spent: 10m
Remaining Estimate: 0h
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --------------------------------------------------
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117: (FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr<HostDBInfo>(r);
> 2110
> CID 1364117: (FORWARD_NULL)
> Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr =
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr<HostDBInfo>(r);
> 2110
> CID 1364117: (FORWARD_NULL)
> Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr =
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
