[
https://issues.apache.org/jira/browse/TS-4948?focusedWorklogId=30406&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30406
]
ASF GitHub Bot logged work on TS-4948:
--------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/16 18:51
Start Date: 11/Oct/16 18:51
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/1092
I'm not very familiar with this code. Was just trying to adjust the logic
to avoid the coverity found NULL error.
We could adjust to send the traffic to the else in line 2179 which appears
to be the error case handling. @SolidWallOfCode do you have an opinion.
Issue Time Tracking
-------------------
Worklog Id: (was: 30406)
Time Spent: 50m (was: 40m)
> CID 1364117 (Forward NULL) in proxy/http/HttpSM.cc
> --------------------------------------------------
>
> Key: TS-4948
> URL: https://issues.apache.org/jira/browse/TS-4948
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP
> Reporter: Leif Hedstrom
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code}
> *** CID 1364117: (FORWARD_NULL)
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr<HostDBInfo>(r);
> 2110
> CID 1364117: (FORWARD_NULL)
> Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr =
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> /proxy/http/HttpSM.cc: 2111 in HttpSM::process_hostdb_info(HostDBInfo *)()
> 2105 void
> 2106 HttpSM::process_hostdb_info(HostDBInfo *r)
> 2107 {
> 2108 // Increment the refcount to our item, since we are pointing at it
> 2109 t_state.hostdb_entry = Ptr<HostDBInfo>(r);
> 2110
> CID 1364117: (FORWARD_NULL)
> Assigning: "client_addr" = "NULL".
> 2111 sockaddr const *client_addr = NULL;
> 2112 bool use_client_addr =
> t_state.http_config_param->use_client_target_addr == 1 &&
> t_state.client_info.is_transparent &&
> 2113 t_state.dns_info.os_addr_style ==
> HttpTransact::DNSLookupInfo::OS_ADDR_TRY_DEFAULT;
> 2114 if (use_client_addr) {
> 2115 NetVConnection *vc = t_state.state_machine->ua_session ?
> t_state.state_machine->ua_session->get_netvc() : NULL;
> 2116 if (vc) {
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
