Github user zwoop commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1464#discussion_r101803943
  
    --- Diff: proxy/http/HttpConfig.cc ---
    @@ -1255,6 +1257,7 @@ HttpConfig::reconfigure()
       params->oride.parent_connect_attempts       = 
m_master.oride.parent_connect_attempts;
       params->per_parent_connect_attempts         = 
m_master.per_parent_connect_attempts;
       params->parent_connect_timeout              = 
m_master.parent_connect_timeout;
    +  params->parent_failures_update_hostdb       = 
m_master.parent_failures_update_hostdb;
    --- End diff --
    
    Can we make this configuration overridable instead? Or are we positive that 
this is something we always want completely on, or completely off? In general, 
new configurations ought to be overridable unless it's impossible to do so 
(i.e. configs outside of the HttpSM are difficult to make overridable).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to