Github user jrushford commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1464#discussion_r101805199
  
    --- Diff: mgmt/RecordsConfig.cc ---
    @@ -518,6 +518,8 @@ static const RecordElement RecordsConfig[] =
       ,
       {RECT_CONFIG, "proxy.config.http.parent_proxy.connect_attempts_timeout", 
RECD_INT, "30", RECU_DYNAMIC, RR_NULL, RECC_NULL, nullptr, RECA_NULL}
       ,
    +  {RECT_CONFIG, 
"proxy.config.http.update_hostdb_on_parent_proxy_connect_errors", RECD_INT, 
"0", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-1]", RECA_NULL}
    --- End diff --
    
    yeah it is long, i prefer your second suggestion since it's used in the 
http transaction to update or not hostdb.  All the ones named spaced to 
proxy.config.hostdb are internal to hostdb and its configuration.  But if you 
prefer #1, I'll use it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to