bryancall commented on issue #8163:
URL: https://github.com/apache/trafficserver/issues/8163#issuecomment-4827449089

   I am closing this as addressed in current source. The specific case you hit, 
an outbound HTTP/2 stream receiving a DATA frame after the stream was deleted 
(for example a POST body frame crossing an early 504 on the wire), is now 
treated as innocuous: ATS sends an RST_STREAM with NO_ERROR and returns an 
error class of NONE, so it no longer counts toward 
proxy.config.http2.stream_error_rate_threshold 
(src/proxy/http2/Http2ConnectionState.cc). maskit's half-closed (local) 
suggestion is also reflected, with DATA in the half-closed (local) state now 
accepted and the closed and half-closed (remote) cases reset without being 
counted as a stream error. Separately, the interaction you noted, where raising 
the rate threshold shrinks the effective sample size, was fixed by 
https://github.com/apache/trafficserver/pull/8506, which added 
proxy.config.http2.stream_error_sampling_threshold (default 10) and first 
shipped in 9.2.0. The default rate threshold remains 0.1, since raising it to 
0.5 was
  an operational tuning choice rather than part of the bug. If you still see 
over-eager GOAWAY behavior on a current release, please open a new issue with 
details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to