zuston commented on code in PR #210:
URL: https://github.com/apache/incubator-uniffle/pull/210#discussion_r976098369
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SelectStorageStrategy.java:
##########
@@ -17,24 +17,14 @@
package org.apache.uniffle.coordinator;
+import java.util.List;
import java.util.Map;
-import org.apache.uniffle.common.RemoteStorageInfo;
+import org.apache.hadoop.fs.Path;
+
import
org.apache.uniffle.coordinator.LowestIOSampleCostSelectStorageStrategy.RankValue;
public interface SelectStorageStrategy {
- RemoteStorageInfo pickRemoteStorage(String appId);
-
- void incRemoteStorageCounter(String remoteStoragePath);
-
- void decRemoteStorageCounter(String storagePath);
-
- void removePathFromCounter(String storagePath);
-
- Map<String, RemoteStorageInfo> getAvailableRemoteStorageInfo();
-
- Map<String, RemoteStorageInfo> getAppIdToRemoteStorageInfo();
-
- Map<String, RankValue> getRemoteStoragePathRankValue();
+ List<Map.Entry<String, RankValue>> sortPathByRankValue(String path, Path
testPath, long time, boolean isHealthy);
Review Comment:
As I know, the object storage also can be accessed by Hadoop Filesystem
Interface (HCFS), like s3/oss/cos. So this is not a problem
But if we want to involve more storages which are not implemented by HCFS or
speed up specified api which is only compatible with original storage api,
maybe we should implement uniffle's own filesystem, it can refer to Flink.
Please let me know if I'm wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
