jerqi commented on code in PR #210:
URL: https://github.com/apache/incubator-uniffle/pull/210#discussion_r977145765
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SelectStorageStrategy.java:
##########
@@ -17,24 +17,12 @@
package org.apache.uniffle.coordinator;
+import java.util.List;
import java.util.Map;
-import org.apache.uniffle.common.RemoteStorageInfo;
import
org.apache.uniffle.coordinator.LowestIOSampleCostSelectStorageStrategy.RankValue;
public interface SelectStorageStrategy {
- RemoteStorageInfo pickRemoteStorage(String appId);
-
- void incRemoteStorageCounter(String remoteStoragePath);
-
- void decRemoteStorageCounter(String storagePath);
-
- void removePathFromCounter(String storagePath);
-
- Map<String, RemoteStorageInfo> getAvailableRemoteStorageInfo();
-
- Map<String, RemoteStorageInfo> getAppIdToRemoteStorageInfo();
-
- Map<String, RankValue> getRemoteStoragePathRankValue();
+ List<Map.Entry<String, RankValue>> readAndWrite(String path);
Review Comment:
I have a little doubt, why do the `readAndWrite` become the only interface
method for SelectStorageStrategy? I can rank by many methods, it's not
necessary to read and write.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
