xianjingfeng commented on code in PR #166:
URL: https://github.com/apache/incubator-uniffle/pull/166#discussion_r976250599
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -158,6 +158,12 @@ public class RssBaseConf extends RssConf {
.defaultValue(true)
.withDescription("The switch for jvm metrics verbose");
+ public static final ConfigOption<String> RSS_SERVER_IP = ConfigOptions
Review Comment:
I think use environment variable is not good in this case, because we need
create mutil ShuffleServer in ut sometimes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
