xianjingfeng commented on code in PR #166:
URL: https://github.com/apache/incubator-uniffle/pull/166#discussion_r977230410
##########
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java:
##########
@@ -191,6 +191,12 @@ public class RssBaseConf extends RssConf {
.defaultValue(60L)
.withDescription("The kerberos authentication relogin interval. unit:
sec");
+ public static final ConfigOption<String> RSS_SERVER_IP = ConfigOptions
Review Comment:
> Could we reuse this environment value?
[6937631](https://github.com/apache/incubator-uniffle/commit/6937631876052425b8d808d26caf78c79b24536a)
Yes, but using environment variables may cause some problems if we create
mutil ShuffleServer in ut, should we reuse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
