jerqi commented on code in PR #210:
URL: https://github.com/apache/incubator-uniffle/pull/210#discussion_r979174647
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SelectStorageStrategy.java:
##########
@@ -17,24 +17,14 @@
package org.apache.uniffle.coordinator;
+import java.util.List;
import java.util.Map;
-import org.apache.uniffle.common.RemoteStorageInfo;
import
org.apache.uniffle.coordinator.LowestIOSampleCostSelectStorageStrategy.RankValue;
public interface SelectStorageStrategy {
- RemoteStorageInfo pickRemoteStorage(String appId);
+ List<Map.Entry<String, RankValue>> detectStorage(String path);
Review Comment:
`path -> uri`?
Path is not general concept for storage. Maybe we should use uri.
##########
coordinator/src/main/java/org/apache/uniffle/coordinator/SelectStorageStrategy.java:
##########
@@ -17,24 +17,14 @@
package org.apache.uniffle.coordinator;
+import java.util.List;
import java.util.Map;
-import org.apache.uniffle.common.RemoteStorageInfo;
import
org.apache.uniffle.coordinator.LowestIOSampleCostSelectStorageStrategy.RankValue;
public interface SelectStorageStrategy {
- RemoteStorageInfo pickRemoteStorage(String appId);
+ List<Map.Entry<String, RankValue>> detectStorage(String path);
- void incRemoteStorageCounter(String remoteStoragePath);
-
- void decRemoteStorageCounter(String storagePath);
-
- void removePathFromCounter(String storagePath);
-
- Map<String, RemoteStorageInfo> getAvailableRemoteStorageInfo();
-
- Map<String, RemoteStorageInfo> getAppIdToRemoteStorageInfo();
-
- Map<String, RankValue> getRemoteStoragePathRankValue();
+ List<Map.Entry<String, RankValue>> pickStorage(List<Map.Entry<String,
RankValue>> pathList);
Review Comment:
Could we give `pathList` a better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
