[ 
https://issues.apache.org/jira/browse/YUNIKORN-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17791435#comment-17791435
 ] 

Wilfred Spiegelenburg commented on YUNIKORN-1089:
-------------------------------------------------

Changed type, target and impact. With the changes we made to support long 
placeholder names we now no longer reject an application with two taskgroups 
that have the exact same name. We create all the placeholders: sum of 
minMembers. The logic in the k8shim however waits for a certain number of 
placeholders to be allocated and that might not be the total created. It also 
could lead to weird behaviour as they two instances with the same name can have 
different resource settings. That in turn could lead to inconsistent scheduling 
behaviour.

We need to look at this with a bit more urgency. [~rainieli] please update if 
you can work on this or un-assign if someone else should take over.

> Application handling with invalid task group annotations
> --------------------------------------------------------
>
>                 Key: YUNIKORN-1089
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1089
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Rainie Li
>            Priority: Critical
>
> In YUNIKORN-1076 we added writing an event to the pod if the task group 
> annotation parsing for a gang request failed. We currently accept the 
> application and schedule it as if it does not have a gang request defined. 
> This might not be what the end user expects.
> The Jira also mentioned failing or rejecting the application if the parsing 
> failed. This is a major change:
>  * the shim currently does never reject an application
>  *  is a broken annotation enough reason to reject the application 
> Moved out the reject or more invasive handling out of the original Jira so we 
> can look at it in more detail.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org

Reply via email to