[
https://issues.apache.org/jira/browse/YUNIKORN-1089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17834409#comment-17834409
]
Ted Lin commented on YUNIKORN-1089:
-----------------------------------
Hi [~wilfreds]
I found that even after removing this piece of code, the gang scheduler still
operates normally.
> * wrapped as the annotation via the tags in the taskGroupsDefinition
* wrapped as the annotation in the metadata as part of the Tags
> Application handling with invalid task group annotations
> --------------------------------------------------------
>
> Key: YUNIKORN-1089
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1089
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: Rainie Li
> Priority: Critical
>
> In YUNIKORN-1076 we added writing an event to the pod if the task group
> annotation parsing for a gang request failed. We currently accept the
> application and schedule it as if it does not have a gang request defined.
> This might not be what the end user expects.
> The Jira also mentioned failing or rejecting the application if the parsing
> failed. This is a major change:
> * the shim currently does never reject an application
> * is a broken annotation enough reason to reject the application
> Moved out the reject or more invasive handling out of the original Jira so we
> can look at it in more detail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: issues-h...@yunikorn.apache.org
