On Tue, Jun 18, 2019 at 01:28:48AM +0000, Luis Chamberlain wrote:
When availble, systemd unit files can be leveraged by users
to enable calling msync for you on a regular basis.

you switch from "by users" to "for you", which isn't very elegant.

This can also
be used to allow you to configure fetching mail at differ[e]nt
intervals for different configurations.

In order to use the systemd unit files a user must explicitly enable
and then start the mbsync systemd timer for themselves:

 systemctl --user stop mbsync-oneshot.timer
 systemctl --user disable mbsync-oneshot.timer

that seems a bit inverted ...

The system default settings are configured to check for mail every 15
minutes for all of your configured channels, and will only trigger if
you have your home directory configuration file ~/.mbsyncrc.

i'm not convinced that it's a good idea to actually install these files, as users are virtually guaranteed to change them. having them as examples in the doc directory seems more appropriate.

If users need to customize the system defaults they are encouraged
to use the system default files as base and install modified versions on their ${XDG_DATA_HOME}/systemd/user ([~/].config/systemd/user/) directory.

diff --git a/Config.mk.in b/Config.mk.in
new file mode 100644
index 0000000..f45a136
--- /dev/null
+++ b/Config.mk.in
@@ -0,0 +1,4 @@
+CONFIG_SYSTEMD_DEV     := @systemddev@
+CONFIG_SYSTEMD_INIT    := @systemdisinit@
+SYSTEMD_CFLAGS         := @SYSTEMD_CFLAGS@
+SYSTEMD_LIBS           := @SYSTEMD_LIBS@

any particular reason why you aren't relying on what AC_SUBST does anyway? the extra file clutters things.

diff --git a/m4/features.m4 b/m4/features.m4
diff --git a/m4/paths.m4 b/m4/paths.m4
diff --git a/m4/systemd.m4 b/m4/systemd.m4

these files contain some weirdness. please make sure to use the latest versions, so i don't comment on already fixed bugs.

but then, these files may be unnecessary to start with when the units get reduced to documentation.

diff --git a/src/mbsync.1 b/src/mbsync.1
index 4dcd5aa..2bad57c 100644
--- a/src/mbsync.1
+++ b/src/mbsync.1
@@ -730,6 +730,53 @@ before the mailbox is expunged.
There is no risk as long as the IMAP mailbox is accessed by only one client
(including \fBmbsync\fR) at a time.
..
+.SH USER SYSTEMD UNITS

i don't like this being in the man page; we don't document other ways of launching, eigher. instead, when the units get moved to a subdir of the doc dir, you can put a README.systemd file next to them. it would probably make sense to make the man page mention the existence of the various examples. (there was the alternative suggestion to inline the examples into the manual, but i personally loathe huge man pages - the flat format just isn't suitable for exhaustive documentation.)



_______________________________________________
isync-devel mailing list
isync-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/isync-devel

Reply via email to