On Sun, Jul 05, 2026 at 07:09:01PM +1000, Seth McDonald wrote:
I do not appreciate being accused of mindlessly using AI.
i didn't say anything about "mindlessly". there is clearly discernment
in your work. there are however patterns that are hallmarks of ai use.
it ultimately doesn't matter to me whether it's actually ai slop, or you
are just being too ambitious and are running out of steam.
this patch doesn't actually fix this.
instead, it abstracts the authentication process as a whole. as far as i'm
concerned, this is simply an obfuscation layer.
The patch had two goals:
1) Un-intertwine the current two implementations.
it doesn't achieve that to any appreciable degree. the cyrus
implementation still hard-codes the login special case, and presumably
that would be duplicated in the gsasl impl.
2) Add the infrastructure to allow a third implementation.
as i said previously, just add the gsasl impl. with ifdefs.
with the code actually being there, you can better judge where _good_
points for abstractions would be. but i'm even more convinced now that
it would be a waste of time.
then it also rewrites (and bloats) the mechanism selection, for no
apparent reason.
[...] This is a benefit of such an interface: it allows more
flexibility with its use.
[...] If mbsync sometime decides to add support for [...]
as i already told you twice, i do not want code that exists "just in
case". and i don't want abstractions that add no practical value.
when i find myself having produced an over-engineered monster that
seems too precious to throw away, it gets stashed away in a wip/ branch.
the second complaint is about the implementation itself: you're joining
the lists early, making the subsequent manipulations require finicky
string operations. that's counter-productive.
also, it's a bad idea to bury such a change inside a refactoring with a
different overall focus. the way to go would be to pull out that part
and make it stand on its own, or show that it's a prerequisite for the
subsequent refactoring. often enough that makes such changes evaporate.
_______________________________________________
isync-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/isync-devel
