--- herman vierendeels
<[EMAIL PROTECTED]> wrote:
> Hello,
> I am trying to understand IText source code.
> (Thanks to all developers for their efforts!).
>
> Is this the right place and method to contribute
> some remarks?
>
> a) dead code ; lines of code who seem to do nothing
>
> source:
> itext-src-1.1.tar.gz
> com.lowagie.text.pdf.PdfPRow.java
> method: public float calculateHeights()
> {
> ...
> ...
> //next line local variable 'table' is not used
> in this method.
> // why asking for it?
> PdfPTable table = cell.getTable();
> ...
> }
>
OK.
> b) names of variables too general to facilitate easy
> search
>
> source:
> itext-src-1.1.tar.gz
> com.lowagie.text.pdf.PdfWriter.java
> ....
> //as this source contains 'pdf' many times, it is
> hard to search
> // for this member variable 'pdf' only
> // why not give it a more difficult name like
> pdfdcmnt ?
> protected PdfDocument pdf;
> .....
>
Why not pdfkjhbkjgbujkugvgv. Is it complicated enough?
It's probably a good idea to analyze first the results
of the automated tool you used and think about what
you're saying. I do a search for "pdf" case sensitive,
whole word and I only get what I want, there's no
confusion.
__________________________________
Do you Yahoo!?
The all-new My Yahoo! - What will yours do?
http://my.yahoo.com
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://productguide.itmanagersjournal.com/
_______________________________________________
iText-questions mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/itext-questions
