> What was the point of adding the "simpler" > mode in the first place btw.?
I didn't make that change and didn't follow the discussion. It was added in ~0.1.10, prior to that most ivtv cards had worked just fine with "simple". > > (as done everywhere, > > No, bttv doesn't. By everywhere I was thinking mostly about ivtv, but sure, lets talk about bttv. Yes, it does bother to initilize vidio_audio before calling the ioctl, I'm sure you also know that in its VIDIOCGAUDIO it is nice enough to also initilize the passed in struct with zeros as well (yes, this is new but as a trend indicator it isn't in the "expect everything to be initialized" line). I count 18 drivers that initilize to zero (or otherwise don't expect a zero state). There are seven (including msp3400) that don't. Only two of those seven don't mention you somewhere in the source (tda7432.c and stradis.c) (not that that is the only measure of what was actually looked at and copied). I'm not arguing it isn't good (or even necessary) to initilize before calling, just that there seems to be little reason not to either initilize the struct when the ioctl is called or at least assume it isn't zero. -- Anduin Withers ------------------------------------------------------- The SF.Net email is sponsored by: Beat the post-holiday blues Get a FREE limited edition SourceForge.net t-shirt from ThinkGeek. It's fun and FREE -- well, almost....http://www.thinkgeek.com/sfshirt _______________________________________________ ivtv-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ivtv-devel
