| From: Tyler Trafford <[EMAIL PROTECTED]>
|
| This patch makes only one functional change,
| I also ran 'indent'* on cx2584-driver.c, and
| went through fixing a huge amount of formating issues that made the
| code hard to work with. It's not perfect, but it's a start
| These changed nothing with how the module runs.
|
| * In case anyone is curious, I used the formatting options in the
| Lindent script included in the kernel, plus '-cbi0'.
I assume that ivtv is kept in CVS (I've just posted a message on this
topic).
The usefulness of the repository is decreased when changes are lumped
together. So I recommend that your two changes be separated.
I certainly agree that cx2584-driver.c was hard to read. I ran indent
on the code to help me understand it. But making such a large set of
changes can make it very hard to use diff to figure out other changes
in the code: a lot of chaff is created by indent.
If one wishes to diff a version from before indenting with one after,
there is a way:
indent old.c >old.indent.c
diff old.indent.c new.c
Unfortunately, you say that you did a lot of manual reformatting.
That makes the diff technique I just mentioned unworkable.
Furthermore, it increases the chance that a non-surface change was
accidentally introduced. I strongly recommend that you find some
indent command that produces an acceptable reformatting without manual
intervention.
/usr/src/linux/Documentation/CodingStyle specifies the kernel coding
style, and this module is intended to be part of the kernel. As it
suggests, you used /usr/src/linux/scripts/lindent. What did you find
it necessary to fix up? Is there any set of flags that can automate
this?
(When I did indent myself, there were a lot of lines that were deeply
indented and broken up very badly by smashing into column 80. I think
that the code looks better with 4 space indentation rather than 8, but
that is not acceptable.)
-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
