> > I did already take a quick look at the previous patch, and I was only > > wondering if adding an "id" attribute to ivy:settings wouldn't cause > > problems since the "id" attribute has a special meaning in Ant. > > > Mmm, yes, you're right, I remember we had a problem with id on cachepath > task. So I'll use settingsId instead of id, unless someone give me a > better > option. >
Personally I preffer to keep the 'id' as it is the standards in ant for reference. We could make it a datatype (again). Indeed the execute method is now finally empty. The only thing it does is to set a default value to the id. But if we make it mandatory, the execute method becomes useless, and the task can be a datatype. IvyConfigure should however stay a task to allow keeping the id optional. I can have a look on it if you want, but it will take a few days to integrate this (and your last changes) into the patch. Gilles
