On 5/31/07, Gilles Scokart <[EMAIL PROTECTED]> wrote:
2007/5/31, Xavier Hanin <[EMAIL PROTECTED]>:
> On 5/31/07, Xavier Hanin <[EMAIL PROTECTED]> wrote:
> >
> > Hi,
> >
> > We discussed recently about using the eclipse tool to clean up the
code to
> > decrease our number of checkstyle errors/warnings.
> >
> > Gilles now you have committed your changes, could we agree on a day
where
> > we could make sure we have no pending changes so that one of us can
run the
> > tool and commit the cleaned up code without needing a merge?
> >
> > Before we should apply the patch from Stephane:
> > https://issues.apache.org/jira/browse/IVY-518
> >
> > On my side I have no pending changes, so any day is ok. I'm ok to
apply
> > the patch and run the clean up tool, I will have time to do it next
week. If
> > anybody else prefer to do it, I'd be happy to oblige :-)
> >
> > We also have to agree on maximum line length, is 100 (the current
setting
> > of checkstyle, borrowed from Ant) ok for everybody?
>
+1 Yes, if it is right for ant people, it should be right for us as well.
A collegue told me once that if your lines are longer, then it is time
to refactor. I think he was right.
>
> One more thing: I think it will be a good opportunity to fix our eol
> inconsistencies: using fixcrlf + applying svn:eol-style property.
> Committers, maybe we should use the Apache settings for svn, to auto
apply
> eol-style:
> http://www.apache.org/dev/svn-eol-style.txt
>
+1
But not that this config will only impact new files. The property
must still be placed on the existing sources.
Indeed, we already have a snippet in our build file to fix this:
<target name="fixcrlf">
<fixcrlf srcdir="${doc.src.dir}" includes="**/*.html,**/*.json"
excludes="samples/**,presentations/**" eol="lf" />
<apply executable="svn">
<arg value="propset"/>
<arg value="svn:eol-style"/>
<arg value='"LF"'/>
<fileset dir="${doc.src.dir}" includes="**/*.html,**/*.json"
excludes="samples/**,presentations/**" />
</apply>
</target>
This one was used for xooki eols (fixed to LF), but it's pretty easy to
adapt it for the other files (using native as eol-style).
Xavier
Gilles
--
Gilles SCOKART
--
Xavier Hanin - Independent Java Consultant
Manage your dependencies with Ivy!
http://incubator.apache.org/ivy/
