On 6/8/07, Gilles Scokart <[EMAIL PROTECTED]> wrote:
I removed the rule in my last commit. Raise a -1 if you disagree.
By the way, I also notice an 'incompatibility" between the eclipse
auto-formating and the checkstyle.
It concerns the length of a line. The auto-formating say to not break
asignment. But with long class names, some simple assignment exceed
the 100 character limits. I have also ssen some exeeded length in
method declaration. Finally, I have seen some line broken like this :
varname
.method(withLonParametersSpliitedOn2Lines);
I would preffer to have
varname.method(
withLonParametersSpliitedOn2Lines);
I tried to update the config, but I'm sure how to do it (a new name
for the formatting settings is asked, I don't know why).
It's strange, I have no such problem. Do you use the project specific
settings and use the edit button? (see attached screenshot).
I also noticed other problems with line lengths, in javadoc comments, it
seems that sometime Eclipse miss the good line length. It seems this are
things which still need to be done by hand.
Xavier
Gilles
2007/6/7, Xavier Hanin <[EMAIL PROTECTED]>:
> On 6/7/07, Gilles Scokart <[EMAIL PROTECTED]> wrote:
> >
> > In our checkstyle config we have the rule 'RedundantModifier'. (see
> > http://checkstyle.sourceforge.net/config_modifier.html).
> >
> >
> >
> > Did we really want to keep this rule? If you want to keep it, it's
ok,
> > we can keep it. But if you have no preference, I would prefer to not
> > use this rule.
> >
> >
> >
> > Personally, I prefer to see public in front of a public method even
when
> > the method is declared in an interface and the public keyword is
> > implicit. I think it make it more clear.
> >
> >
> >
> > WDYT?
>
>
> I have no preference at all, so if you prefer seeing public in front of
> interface methods it's fine for me.
>
> Xavier
>
> Gilles
> >
> > Gilles Scokart
> >
> > E-mail : [EMAIL PROTECTED]
> > Tel : +32
> > Fax : +32
> >
> >
> > Isabel NV/S.A.
> > Keizerinlaan 13-15 Boulevard de l'Imperatrice
> > 1000 Brussels - Belgium
> > RPR Bruxelles / RPM Brussel: BE 0455 530 509
> > www.isabel.eu www.zoomit.eu
> >
> > ZOOMIT is a Registred Trademark of Isabel NV/S.A.
> > Disclaimer : www.isabel.eu/gps/en/disclaimer/mailing.php
> >
>
>
>
> --
> Xavier Hanin - Independent Java Consultant
> Manage your dependencies with Ivy!
> http://incubator.apache.org/ivy/
>
--
Gilles SCOKART
--
Xavier Hanin - Independent Java Consultant
Manage your dependencies with Ivy!
http://incubator.apache.org/ivy/
