elharo commented on code in PR #7:
URL: https://github.com/apache/xerces-j/pull/7#discussion_r2022666862


##########
src/org/apache/xerces/parsers/AbstractDOMParser.java:
##########
@@ -933,6 +942,20 @@ public void startElement (QName element, XMLAttributes 
attributes, Augmentations
                 return;
             }
             Element el = createElementNode (element);
+            // Extract location info if feature is enabled
+            if (fIncludeLocationInfo) {
+                // The fLocator is an XMLLocator object, not a DOMLocator.

Review Comment:
   Do not include code review responses in code comments



##########
src/org/apache/xerces/dom/CoreDocumentImpl.java:
##########
@@ -2441,7 +2441,7 @@ protected void callUserDataHandlers(Node n, Node c, short 
operation) {
         }
         //Hashtable t = (Hashtable) userData.get(n);
                if(n instanceof NodeImpl){
-                       Hashtable t = ((NodeImpl)n).getUserDataRecord();
+                       Hashtable t = ((NodeImpl) n).getUserDataRecord();

Review Comment:
   delete line 2442
   t --> userDataRecord



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to