mbeckerle commented on code in PR #7:
URL: https://github.com/apache/xerces-j/pull/7#discussion_r2039608057
##########
src/org/apache/xerces/dom/CoreDocumentImpl.java:
##########
@@ -2439,10 +2439,9 @@ protected void callUserDataHandlers(Node n, Node c,
short operation) {
if (userData == null) {
return;
}
- //Hashtable t = (Hashtable) userData.get(n);
if(n instanceof NodeImpl){
- Hashtable t = ((NodeImpl)n).getUserDataRecord();
- if (t == null || t.isEmpty()) {
+ Hashtable userDataRecord = ((NodeImpl)
n).getUserDataRecord();
Review Comment:
This change unnecessary. Artifact of a approach no longer being used which
was to put the line/col info into the user data. I do like the new code better
though as it avoids redundant branch logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
