SingingBush commented on code in PR #2:
URL: https://github.com/apache/xerces-j/pull/2#discussion_r2161081511
##########
src/org/apache/xerces/dom/DOMImplementationListImpl.java:
##########
@@ -34,27 +35,27 @@
public class DOMImplementationListImpl implements DOMImplementationList {
// A collection of DOMImplementations
- private final ArrayList fImplementations;
+ private final List<DOMImplementation> fImplementations;
/**
* Construct an empty list of DOMImplementations
*/
public DOMImplementationListImpl() {
- fImplementations = new ArrayList();
+ fImplementations = new ArrayList<>();
}
/**
* Construct a list of DOMImplementations from an ArrayList
*/
- public DOMImplementationListImpl(ArrayList params) {
+ public DOMImplementationListImpl(List<DOMImplementation> params) {
Review Comment:
if the user has an array list of DOMImplementation then accepting a List is
ok but the type info will make it a breaking change if the user isn't using a
typed list. I can go back and remove types from args for constructors and
public functions but perhaps it's time to consider a version bump with small
breaking changes. typed collections have been around so long now that it would
be an easy change for users to make when updating the dependency. However, I've
now removed the type from the collection
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
