mrglavas commented on code in PR #2:
URL: https://github.com/apache/xerces-j/pull/2#discussion_r2162068507
##########
src/org/apache/xerces/dom/DOMImplementationListImpl.java:
##########
@@ -34,27 +35,27 @@
public class DOMImplementationListImpl implements DOMImplementationList {
// A collection of DOMImplementations
- private final ArrayList fImplementations;
+ private final List<DOMImplementation> fImplementations;
/**
* Construct an empty list of DOMImplementations
*/
public DOMImplementationListImpl() {
- fImplementations = new ArrayList();
+ fImplementations = new ArrayList<>();
}
/**
* Construct a list of DOMImplementations from an ArrayList
*/
- public DOMImplementationListImpl(ArrayList params) {
+ public DOMImplementationListImpl(List<DOMImplementation> params) {
Review Comment:
I haven't checked where this is in the code but I've learned from experience
with users that some of them do have dependencies on internal APIs and have
seen examples in books and articles which unfortunately encourage this. So much
of Xerces has been effectively stable for 20+ years. I think there needs to be
a more compelling reason to update public signatures than just doing it for the
sake of doing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
