> Subject: [PATCH 3/8] arm64: smmu: Clarify that mapping mismatch is just a
> warning
> 
> From: Jan Kiszka <jan.kis...@siemens.com>
> 
> The Linux kernel commit c55af7f719cb writes:
> 
> "Such a mismatch could be intentional (to fix wrong register values).
> If its not intentional (e.g. due to wrong DT information) this will very 
> likely
> cause a malfunction of the driver as SMMU_CB_BASE is derived from the size
> of the mapped region. The warning helps to identify the root cause in this
> case."
> 
> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>
> ---
>  hypervisor/arch/arm64/smmu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/hypervisor/arch/arm64/smmu.c b/hypervisor/arch/arm64/smmu.c
> index 3b2d6e15..e8dbf186 100644
> --- a/hypervisor/arch/arm64/smmu.c
> +++ b/hypervisor/arch/arm64/smmu.c
> @@ -679,7 +679,8 @@ static int arm_smmu_device_cfg_probe(struct
> arm_smmu_device *smmu)
>       size = 1 << (((id >> ID1_NUMPAGENDXB_SHIFT) &
> ID1_NUMPAGENDXB_MASK) + 1);
>       size <<= smmu->pgshift;
>       if (smmu->cb_base != gr0_base + size)
> -             printk("SMMU address space size (0x%lx) differs from mapped
> region size (0x%tx)!\n",
> +             printk("Warning: SMMU address space size (0x%lx) "
> +                    "differs from mapped region size (0x%tx)!\n",
>                      size * 2, (smmu->cb_base - gr0_base) * 2);
> 
>       smmu->num_s2_context_banks = (id >> ID1_NUMS2CB_SHIFT) &
> ID1_NUMS2CB_MASK;

Reviewed-by: Peng Fan <peng....@nxp.com>

> --
> 2.26.2

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jailhouse-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/DB6PR0402MB2760E292EA149F698A6AD32388340%40DB6PR0402MB2760.eurprd04.prod.outlook.com.

Reply via email to