> Subject: [PATCH 6/8] arm64: smmu: Drop duplicate error messages
> 
> From: Jan Kiszka <jan.kis...@siemens.com>
> 
> arm_smmu_tlb_sync_global already reports when it fails.
> 
> Signed-off-by: Jan Kiszka <jan.kis...@siemens.com>
> ---
>  hypervisor/arch/arm64/smmu.c | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/hypervisor/arch/arm64/smmu.c b/hypervisor/arch/arm64/smmu.c
> index 2cd5157c..b89291e7 100644
> --- a/hypervisor/arch/arm64/smmu.c
> +++ b/hypervisor/arch/arm64/smmu.c
> @@ -887,10 +887,8 @@ static int arm_smmu_cell_init(struct cell *cell)
>               mmio_write32(ARM_SMMU_GR0(&smmu_device[i])
>                            + ARM_SMMU_GR0_TLBIVMID, cfg->vmid);
>               ret = arm_smmu_tlb_sync_global(&smmu_device[i]);
> -             if (ret < 0) {
> -                     printk("TLB maintenance operations globally across the 
> SMMU
> failed!\n");
> +             if (ret < 0)
>                       return ret;
> -             }
>       }
> 
>       return 0;
> @@ -918,9 +916,7 @@ static void arm_smmu_cell_exit(struct cell *cell)
> 
>               mmio_write32(ARM_SMMU_GR0(&smmu_device[i]) +
> ARM_SMMU_GR0_TLBIVMID,
>                                         smmu_device[i].cbs[cbndx].cfg->vmid);
> -             ret = arm_smmu_tlb_sync_global(&smmu_device[i]);
> -             if (ret < 0)
> -                     printk("TLB maintenance operations globally across the 
> SMMU
> failed!\n");
> +             arm_smmu_tlb_sync_global(&smmu_device[i]);
> 
>               for_each_smmu_sid(sid, cell->config, n) {
>                       ret = arm_smmu_find_sme(*sid,

Reviewed-by: Peng Fan <peng....@nxp.com>

> --
> 2.26.2

-- 
You received this message because you are subscribed to the Google Groups 
"Jailhouse" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to jailhouse-dev+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/jailhouse-dev/DB6PR0402MB2760B0C979C4A651C2F9B63D88340%40DB6PR0402MB2760.eurprd04.prod.outlook.com.

Reply via email to