It seems I was aware of this one day ;)

Issue closed.

2008/12/23, Sebastien Lelong <[email protected]>:
> Then also have a look at issue 18:
> http://code.google.com/p/jallib/issues/detail?id=18
>
> Great this is now checked, even if it's a workaround
>
> Seb
>
> 2008/12/23 Joep Suijs <[email protected]>
>
> >
> > No....
> >
> > I was not aware of this and found out the hard way: it did not work at
> > first and I created a work-around.
> >
> > Joep
> >
> > 2008/12/23, Sebastien Lelong <[email protected]>:
> >
> >
> >
> > > Does this mean compiler issue 22 "Compiler cannot compare negative and
> > > positive constants" was fixed iun 2.4i ?
> > >
> > > http://code.google.com/p/jallib/issues/detail?id=22
> > >
> > >
> > > Seb
> > >
> > > 2008/12/23 <[email protected]>
> > > >
> > > > Author: jsuijs
> > > > Date: Tue Dec 23 01:10:19 2008
> > > > New Revision: 640
> > > >
> > > > Modified:
> > > >
> > >
> trunk/unvalidated/include/peripheral/usart/serial_hardware.jal
> > > >
> > > > Log:
> > > > added validation for max baudrate deviation
> > > >
> > > > Modified:
> > >
> trunk/unvalidated/include/peripheral/usart/serial_hardware.jal
> > > >
> > >
> ==============================================================================
> > > > ---
> > >
> trunk/unvalidated/include/peripheral/usart/serial_hardware.jal
> > > > (original)
> > > > +++
> > >
> trunk/unvalidated/include/peripheral/usart/serial_hardware.jal
> > >      Tue Dec
> > > > 23 01:10:19 2008
> > > > @@ -67,13 +67,24 @@
> > > >
> > > >        -- if divider small enough,
> > > >        -- calculate divider and set high-speed
> > > > +      const real_baud = target_clock / 16 / (usart_div + 1)
> > > >        if usart_div <= 255 then
> > > > -           if usart_div >= 0 then
> > > > +         if (real_baud > serial_hw_baudrate) then
> > > > +            if (100 * (real_baud - serial_hw_baudrate) /
> > > > serial_hw_baudrate >= max_deviation) then
> > > > +               pragma error  -- asynchronous baudrate deviation is
> too
> > > > large
> > > > +            end if
> > > > +         else
> > > > +            if (100 * (serial_hw_baudrate - real_baud) /
> > > > serial_hw_baudrate >= max_deviation) then
> > > > +               pragma error  -- asynchronous baudrate deviation is
> too
> > > > large
> > > > +            end if
> > > > +         end if
> > > > +
> > > > +         if usart_div >= 0 then
> > > >              SPBRG = usart_div
> > > >           else
> > > >              SPBRG = 0
> > > >           end if
> > > > -           TXSTA_BRGH = true
> > > > +         TXSTA_BRGH = true
> > > >           -- try the low-speed mode
> > > >        else
> > > >             const usart_div_low = ((((10 * target_clock) / ( 64 *
> > > > serial_hw_baudrate )) + 5 ) / 10) - 1
> > > >
> > > >
> > > >
> > >
> > >
> > >
> > > --
> >
> > > Sébastien Lelong
> > > http://www.sirloon.net
> > > http://sirbot.org
> > >
> > > >
> > >
> >
> >
> >
> >
> >
> >
>
>
>
> --
> Sébastien Lelong
> http://www.sirloon.net
> http://sirbot.org
>
> >
>

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to