Joep,

While browsing the hd44780 libs ....

I see and inconsistency: the old libs use for 0-base line numbers,
while (parts of) Richards use 1-base. Should be corrected!  I believe we
agreed to make 0-base the standard, because that matches the compilers
array-indexing JalV2. If not it is my proposal to use only 0-base.

I see that lcd_clear_line() accepts only lines 1 en 2. That should
become 0,1,2 en 3, and the body of the proc should be adapted.
I don't understand the '39' in the for-loop, I would expect 40.  And it
should not be a hard coded digit, but LCD_CHARS.

Why are the 'pragma inline' statements commented out? I thought the
compiler problems with 'inline' were solved, weren't they?

Groeten, Rob.


PS: I've committed my mods.


-- 
Rob Hamerling, Vianen, NL (http://www.robh.nl/)

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to