Richard, Rob, Richard is right that, although svn handles merges pretty good, we should not have to many people working on the same lib. It seems that I set too much in motion but I expect the result to be good ;)
I'll try to adapt hd44780_common at the end of the week. I also choose to use clear_screen format - with the underscore - like other libs. I'll keep the few old hd44780 functions for compatibility. As for hd44780_4 and 8 - I think they are stable as API is concerned. I'll work on the cleanup of the code and (mostly) comment later. For you Richard, I gueass this means you can work on the interface part of dogm (since the 'lower' api of hd44780_common is stable). Joep 2009/2/25 Ritchie <[email protected]>: > > > > On 24 feb, 21:03, Rob Hamerling <[email protected]> wrote: >> Joep, >> >> While browsing the hd44780 libs .... >> >> I see and inconsistency: the old libs use for 0-base line numbers, >> while (parts of) Richards use 1-base. Should be corrected! I believe we >> agreed to make 0-base the standard, because that matches the compilers >> array-indexing JalV2. If not it is my proposal to use only 0-base. > > Yes Rob i know jallib uses 0-base and i use(d) 1-base and if you want > to use the fuctions it should be > changed to 0-base ( i already deed on my local libs) > The libs where never addapted to jallib because i thought you where > not interested in my libs only youre own. > but i noticed Elektor usses the dogm diplay in one of his articles > this mounth and thought maybe it would be nice > to still addaped the st7036 to jallib if they are interested. > > discused with Joep in "r799" and we started to change. > but its better for me to wait and see what this all brings > >> >> I see that lcd_clear_line() accepts only lines 1 en 2. That should >> become 0,1,2 en 3, and the body of the proc should be adapted. > > also yes i use a 2 line lcd but for jallib standard this sould be > indeed 0 to 3 lines > >> I don't understand the '39' in the for-loop, I would expect 40. And it >> should not be a hard coded digit, but LCD_CHARS. > > if "for 39 loop"starts at 1 you are right but i asumed it start with > 0 > >> >> Why are the 'pragma inline' statements commented out? I thought the >> compiler problems with 'inline' were solved, weren't they? >> >> Groeten, Rob. >> >> PS: I've committed my mods. >> >> -- >> Rob Hamerling, Vianen, NL (http://www.robh.nl/) > > > > Richard > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
