On Mar 8, 8:01 am, Joep Suijs <[email protected]> wrote:
> Hi Richard & others
>
> > I would love to modify and cleanup lcd_hd44780_common
>
> What kind of changes do you suggest?
maybe remove:
const lcd_clear_display = 0b_0000_0001 -- long
delay
const lcd_return_home = 0b_0000_0010 -- long
delay
const lcd_display_onoff = 0b_0000_1000 -- short
delay
const lcd_cursor_shift_r_val = 0b_0001_0100
const lcd_cursor_shift_l_val = 0b_0001_0000
const lcd_display_shift_right = 0b_0001_1100
const lcd_display_shift_left = 0b_0001_1000
const lcd_set_ddram_address = 0b_1000_0000
const lcd_set_cgram_address = 0b_0100_0000
and place in lcd_hd44780_4 and lcd_hd44780_8 like simulair to the dogm
files or shall i remove the ones in the dogm files?
i was thinking about removing the line and poskar in the procedure
lcd_bvalue_dp_line_pos_left_sign() and
lcd_wvalue_dp_line_pos_left_sign ( ) so this will become
lcd_bvalue_dp_left_sign( byte in value, byte in dp, bit in left, bit
in sign ) and lcd_wvalue_dp_line_pos_left_sign ( word in value, byte
in dp, bit in left, bit in sign )
what do you think?
> I'll be working on this file today and do some cleanup. So tomorrow
> would be a good check again.
ok i will wait with modifing my test files.
>
> > and please let we
> > rename to lcd_common instead of lcd_hd44780_common so that we can use it
> > for maybe other (non hd448780) lcd's in the futher.
>
> I thought about this but decided for this name. The reason is that
> there are many displays that are not compatible with hd44780 (I have
> two here: a graphics lcd and a starburst one).
> So it is better to give a more distinct name to the lib, since we can
> expect more shared lcd libs. But it is a lib that is not included by
> the end user and you can use it for any display that is hd44780
> compatible (like dogm) without the user noticing.
ok, no problem forgot it is not used by end user.
what is your opinion about combining spi, 4bit and 8bit to one file in
stead of 3 file now?
Richard
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en
-~----------~----~----~----~------~----~------~--~---
