Hi Richard, 2009/3/8 Richard <[email protected]>: >> What kind of changes do you suggest? > > maybe remove: > > const lcd_clear_display = 0b_0000_0001 -- long > delay > const lcd_return_home = 0b_0000_0010 -- long > delay > const lcd_display_onoff = 0b_0000_1000 -- short > delay > const lcd_cursor_shift_r_val = 0b_0001_0100 > const lcd_cursor_shift_l_val = 0b_0001_0000 > const lcd_display_shift_right = 0b_0001_1100 > const lcd_display_shift_left = 0b_0001_1000 > const lcd_set_ddram_address = 0b_1000_0000 > const lcd_set_cgram_address = 0b_0100_0000 > > and place in lcd_hd44780_4 and lcd_hd44780_8 like simulair to the dogm > files or shall i remove the ones in the dogm files? I suggest you remove them from the dogm files, so they only have to be maintained at one place. (i had a quick look and guess they are the same for dogm, aren't they?)
> i was thinking about removing the line and poskar in the procedure > lcd_bvalue_dp_line_pos_left_sign() and > lcd_wvalue_dp_line_pos_left_sign ( ) so this will become > lcd_bvalue_dp_left_sign( byte in value, byte in dp, bit in left, bit > in sign ) and lcd_wvalue_dp_line_pos_left_sign ( word in value, byte > in dp, bit in left, bit in sign ) > what do you think? I did not look into these yet, but someone should! Do I understand correctly these routines combine two things: 1. place the cursor at a designated position 2. print a number in a specified (fixed point) format If this is the case, I would suggest to split this: 1. use lcd_cursor_position() to place the cursor 2. use a function from format.jal to output the number. see format_byte_dec(). There is however an remaining issue with format.jal. See jallib issue 27 for details. Could you have a look if format.jal provides a decent replacement for the procedures mentions? And it would be great if you could (some of) the rework mentioned in issue 27! >> I'll be working on this file today and do some cleanup. So tomorrow >> would be a good check again. > > ok i will wait with modifing my test files. I'm done now :) > what is your opinion about combining spi, 4bit and 8bit to one file in > stead of 3 file now? This is okay with me. And you could even add i2c to it ;) But can you explain what the difference is between the dogm 4bit and hd44780 4bit? Joep PS I had a look at the dogm display at Conrad, but they are a bit too expensive to buy one just for testing... I might buy myself a blue graphic 240*128 lcd from voti when I am done with the 128*64 at hand ;) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/jallib?hl=en -~----------~----~----~----~------~----~------~--~---
