Jean Marchaudon library was the reference for all modifications. Vasile
On Fri, Jan 14, 2011 at 12:30 AM, Florin Tanasa <[email protected]>wrote: > > > Joep Suijs <[email protected]> wrote: > > >And an other question: who is the orignal (first) author of: > >-- 1 wire JAL library for the DS18B20 > >-- > >-- file : ds18b20.jal > >-- authors : And-Tech.pl, Bert van Dam, Jean Marchaudon, Olivier Seitz > >-- : Vasile Surducan > > > >Joep > > > > > >2011/1/13 Joep Suijs <[email protected]>: > >> Hi Vasi, > >> > >> Can you confirm that thermometer.jal is intended for a single device > >> on the 1wire bus and thermometer2.jal potentially supports more > >> devices? > >> If so, it is probably best to start a test file with thermometer that > >> shows the use of all the relevant functions of the lib. There are > >> quite a few procedures and there function is 'quite briefly' > >> documented and not shown in the samples. And the ones that are used, > >> have no explanation (in contrast to the lcd use ;). So some work to > >> do. > >> > >> An other thing is the parameter max_crc_errors. I think this is the > >> maximum number of retries. Correct? > >> Such a parameter suggests crc errors are quite common. How often do > >> you get CRC errors? Also, does it make sense to pass this as a > >> parameter? If it is a fixed value, we could add a constant. But when > >> there is a limited number of retries, there remains a chance that get > >> invalid reading back. And how would you act upon this? Maybe it makes > >> more sense to have a constant that either says unlimited retries or no > >> (automatic) retries at all, but return a succes indicator. If your > >> program has to handle the error, it will probably has some retry > >> mechanism anyway. Or do I miss something? > >> > >> Once the first test-file is done, it would be good to create a second > >> one to show the use of multiple devices on the bus. Are you able to > >> create a program (like termometer2) which works with two (or more) > >> devices on the same bus? Does the library support discovery of devices > >> on such a bus or should one first determine the ID of each device when > >> they are alone? > >> > >> Joep > >> > >> 2011/1/13 Joep Suijs <[email protected]>: > >>> Hi Vasi, > >>> > >>> I start working on it but had not much time. With a bit of luck, I can > >>> spend a few hours tonight and probably send you some questions. > >>> For now, I am okay ;) > >>> > >>> Joep > >>> > >>> 2011/1/13 funlw65(Vasi) <[email protected]>: > >>>> I don't compiled using SVN version. > >>>> For the file 18f2550_ds18b20_therm.jal I have: > >>>> > >>>> jal 2.4n (compiled Jun 2 2010) > >>>> 0 errors, 0 warnings > >>>> Code area: 2294 of 32768 used (bytes) > >>>> Data area: 81 of 928 used > >>>> Software stack available: 847 bytes > >>>> Hardware stack depth 5 of 31 > >>>> > >>>> and for the file 18f2550_ds18b20_therm2.jal I have: > >>>> jal 2.4n (compiled Jun 2 2010) > >>>> 0 errors, 0 warnings > >>>> Code area: 2104 of 32768 used (bytes) > >>>> Data area: 80 of 928 used > >>>> Software stack available: 848 bytes > >>>> Hardware stack depth 5 of 31 > >>>> > >>>> > >>>> On Jan 13, 11:03 am, "funlw65(Vasi)" <[email protected]> wrote: > >>>>> Hi Joep, > >>>>> > >>>>> I think I did not touched 1_wire.jal, is as it is from Bert > package... > >>>>> > >>>>> I compared them with Winmerge: I added a line in comments and better > >>>>> arranged two if structure, without touching the code logic. > >>>>> > >>>>> Vasi > >>>>> > >>>>> On Jan 12, 6:04 pm, Joep Suijs <[email protected]> wrote: > >>>>> > >>>>> > Vasi, > >>>>> > >>>>> > If fixed part of the problem: the garbage in the files came either > >>>>> > from gmail or Microsoft :( > >>>>> > Only the pragma issue remains. I don't understand why, but this is > not > >>>>> > relevant since I'll move it to a board file anyway. > >>>>> > Just to be certain: I have the 18-8 version of 1wire.jal. Is this > the > >>>>> > correct one? > >>>>> > >>>>> > Thanks, > >>>>> > Joep > >>>>> > >>>>> > 2011/1/12 Joep Suijs <[email protected]>: > >>>>> > >>>>> > > Hi Vasi, > >>>>> > >>>>> > > In your 15-12 version, 1_wire.jal is missing. When I grab the one > you > >>>>> > > original posted and try to compile it I get: > >>>>> > >>>>> > > jal 2.4n (compiled Jun 2 2010) > >>>>> > > generating p-code > >>>>> > > 18f2550_ds18b20_therm2.jal:17: unknown pragma target: voltage > pragma > >>>>> > > 18f2550_ds18b20_therm2.jal:21: unknown pragma target: ccp2mux > pragma > >>>>> > > 1_wire.jal:95: "x" not defined > >>>>> > > 1_wire.jal:96: unexpected token: "end" > >>>>> > >ds18b20.jal:248: "t" not defined > >>>>> > >ds18b20.jal:248: unexpected token: "t" > >>>>> > > 18f2550_ds18b20_therm2.jal:134: unexpected token: ""e"" > >>>>> > > 7 errors, 0 warnings > >>>>> > >>>>> > > It seems that all three files have issue's. E.g. in the crc > routine of > >>>>> > >ds18b20, line 248 is "t tmp_1_7 shared at tmp[1] : 7", which is > not > >>>>> > > valid JAL. Also there are some fuse-related messages. > >>>>> > > Are you compiling against the svn version of jallib? And can you > post > >>>>> > > a compilable set of files? > >>>>> > >>>>> > > Thanks, > >>>>> > > Joep > >>>>> > > 2011/1/12 funlw65(Vasi) <[email protected]>: > >>>>> > >> Can't wait to see the result :) > >>>>> > >>>>> > >> On Jan 12, 9:30 am, Joep Suijs <[email protected]> wrote: > >>>>> > >>> Hi Vasi, > >>>>> > >>>>> > >>> Thanks for you work. I will start working on this library set > (I have > >>>>> > >>> the chips now ;) > >>>>> > >>>>> > >>> Joep > >>>>> > >>>>> > >>> 2011/1/11 funlw65(Vasi) <[email protected]>: > >>>>> > >>>>> > >>> > Thank you very much. > >>>>> > >>> > Joep, all three authors agree with the change of license for > inclusion > >>>>> > >>> > in Jallib. > >>>>> > >>>>> > >>> > Vasi > >>>>> > >>>>> > >>> > On Jan 11, 11:07 pm, "jfm68" <[email protected]> wrote: > >>>>> > >>> >> hi, > >>>>> > >>>>> > >>> >> for me, it's ok . > >>>>> > >>> >> this part my work is completely free, you can use and reuse > it. > >>>>> > >>>>> > >>> >> jean Marchaudon > >>>>> > >>>>> > >>> >> ----- Original Message ----- > >>>>> > >>> >> From: "funlw65(Vasi)" <[email protected]> > >>>>> > >>> >> To: "jallib" <[email protected]> > >>>>> > >>> >> Sent: Tuesday, January 11, 2011 9:41 AM > >>>>> > >>> >> Subject: [jallib] Re: One wire library > >>>>> > >>>>> > >>> >> Ok, I will contact them. > >>>>> > >>>>> > >>> >> On Jan 11, 9:32 am, Joep Suijs <[email protected]> wrote: > >>>>> > >>> >> > Hi Vasi, > >>>>> > >>>>> > >>> >> > > If I remember well, Marchaudon said it > >>>>> > >>> >> > > is ok. Remains Vasile and Bert. > >>>>> > >>>>> > >>> >> > To change the license, I'd like to have the conformation > from all > >>>>> > >>> >> > three. Will you look into this? > >>>>> > >>> >> > The license need to be changed to add the library to > jallib. > >>>>> > >>>>> > >>> >> > Joep > >>>>> > >>>>> > >>> >> -- > >>>>> > >>> >> You received this message because you are subscribed to the > Google Groups > >>>>> > >>> >> "jallib" group. > >>>>> > >>> >> To post to this group, send email to > [email protected]. > >>>>> > >>> >> To unsubscribe from this group, send email to > >>>>> > >>> >> [email protected]<jallib%[email protected]> > . > >>>>> > >>> >> For more options, visit this group athttp:// > groups.google.com/group/jallib?hl=en. > >>>>> > >>>>> > >>> > -- > >>>>> > >>> > You received this message because you are subscribed to the > Google Groups "jallib" group. > >>>>> > >>> > To post to this group, send email to [email protected] > . > >>>>> > >>> > To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > >>>>> > >>> > For more options, visit this group athttp:// > groups.google.com/group/jallib?hl=en. > >>>>> > >>>>> > >> -- > >>>>> > >> You received this message because you are subscribed to the > Google Groups "jallib" group. > >>>>> > >> To post to this group, send email to [email protected]. > >>>>> > >> To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > >>>>> > >> For more options, visit this group athttp:// > groups.google.com/group/jallib?hl=en. > >>>> > >>>> -- > >>>> You received this message because you are subscribed to the Google > Groups "jallib" group. > >>>> To post to this group, send email to [email protected]. > >>>> To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > >>>> For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > >>>> > >>>> > >>> > >> > > > >-- > >You received this message because you are subscribed to the Google Groups > "jallib" group. > >To post to this group, send email to [email protected]. > >To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > >For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]<jallib%[email protected]> > . > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
