I'm not sure if I should talk about this stuff here or in the opened
issue.
glcd_font_use(), maybe just name it glcd_font().
What is the purpose of lcd_gotoxy(x,y) in glcd_nokia_3310? In
stm032qvt-003, there is a procedure named
glcd_address_set(x1,y1,x2,y2). Maybe these are similar in some way. In
stm032qvt-003, this procedure is used for quick printing of pixels
starting at x1,y1 ending at x2,y2. It is faster since you do not need
to specify location of every pixel. Later on, a font procedure should
be made with this pixel writing method.
As for fonts, I see you have properties for:
_glcd_font_current_id = FONT_5X7
_glcd_font_current_bpc = FONT_5X7_BPC
_glcd_font_current_width = FONT_5X7_WIDTH
_glcd_font_current_height = FONT_5X7_HEIGHT
but maybe FONT_BIT_DIRECTION should be added to this list. This will
allow someone to use more then one bit-direction font. Every font
should have this property so a font printing proc can understand it.
I'm not sure what FONT_5X7_BPC is, I assume it is bytes per character.
why not name it FONT_5X7_BYTES_PER_CHARACTER?
I also worry about the font number - FONT_5X7 = 0x01
Should this go int constants_jallib or font.jal? otherwise we need to
read every font lib to get a number that is not in use (if we add a
font). I know the correct place for it is in each font lib, but it
would make life easy if it is somewhere else.
You will see a old lcd_line() procedure in glcd_common.jal, this proc
did not work for me and was therefore replaced. Could you please test
this new proc?
Matt.
--
You received this message because you are subscribed to the Google Groups
"jallib" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/jallib?hl=en.
