2011/5/6 William <[email protected]> > > On May 6, 7:23 am, Sebastien Lelong <[email protected]> > wrote: > > > > > > As to why you wanted to rewrite spi_init to use your new routines, I > > > have no idea. > > > > Because SD card lib doesn't have to deal directly with SPI registers > (direct > > access to device file == device file layer) but instead ask SPI lib to > set > > it (access to SPI lib == spi lib layer). That's why I was talking about > > different layers. This done, it's now easy to use SD card with MSSP1, > MSSP2 > > or SPI software, because actual registers are hidden behind a procedure. > > That's why we did this. > > > > Apparently we continue to mis-communicate -- you keep explaining about > mssp2 and software-spi features, which are wonderful I am sure. But I > am not challenging that at all-- I'm just wanting to to restore the > spi_init() routine back to its original form -- it will still work > fine with mssp2. >
But the trouble isn't MSSP2 will not work, the trouble is in sd-card lib ! Previously, in sd_card lib, there were the following lines: procedure sd_init() is -- put spi into mode 11 SSPCON_CKP = 1 SSPSTAT_CKE = 0 => (1) direct access to device file register (2) duplication of code as it's already done in spi lib. Two reasons why we changed this into: procedure sd_init() is spi_master_set_mode(SPI_MODE_11) ... (see again revision 2587 http://code.google.com/p/jallib/source/browse/trunk/include/external/storage/sd_card/sd_card.jal?r=2587, and log: "uses generic aliases to set mode, no morec direct MSSP register access. Aliases default to MSSP1 for backward compatibility & user-friendly usage". > > OK, I understand that. but I also didn't want to put my name as author on > > spi_master_hw2.jal: even if you didn't create this file, you're still the > > author in some way. > > No, you created a new file that didn't exist before. It is a > derivative work, and you can and should credit the original but it is > your work and presumably you will handle support issues, not me. > This really isn't the way author field is currently considered. Take Stef's lib. He's the author of many libs here in jallib. Because he did all the hard work, putting his brain juice into code lines. We, at jallib, just adapted his work to fit API & style. (that said, adapter can sometime doing a much more difficult work than this author himself, but that's for another day :)) If your "Author" field concern is about handle support, there's no relation about author and support. We just do our best, all of us. Most of time, as matter of fact but not a matter of "due", author is the best person to give support, but well, you know, Albert did an incredible job with his USB libs, but he's not around here anymore (or rarely). Still, we try to provide support, even for this huge piece of code. It ain't easy, of course, but we're doing our best. Cheers, Seb -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
