Hi, As I am using this library right now, I have small remarks:
- Cosmetic: In the comments on lines 254 and 259, reference is made to the SSD1306 - Functionality leading to mistakes: the logic in the "procedure rtc_alarm_2_flag'put(bit in set_flag)" and "procedure rtc_alarm_1_flag'put(bit in set_flag)" allows to set the bit to 1. But on page 15 of the datasheet, it is stated that this bit may only be written to 0. Allowing the user to write it to 1 may lead to mistakes, since the user may believe it actually worked, when it didn't. My suggestion: Deprecate with a WARN at compile time those 2 procedures and replace them with a "procedure clear_rtc_alarm_2_flag'put"(and the same for alarm 1) Just my 2c, hoping to help, and not to critisize the good work done ! Enjoy your week-end. David. -- You received this message because you are subscribed to the Google Groups "jallib" group. To unsubscribe from this group and stop receiving emails from it, send an email to jallib+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/8b00121b-9f7e-4228-8831-13b4d3ccc9fbn%40googlegroups.com.
