Peter, if you've cured every instance of string concatenation in james three things spring to mind,
1/ get a life mate ;-) 2/ check very carefully that you have diff'd the HEAD and send them all in one go (if you send a single big file with them all concatenated I can *try* to apply them in one fell swoop, try diffing them all at once and capturing the whole output) 3/ You'd better make sure it really all works first time. d. > -----Original Message----- > From: Peter M. Goldstein [mailto:[EMAIL PROTECTED]] > Sent: 28 July 2002 21:16 > To: 'James Developers List' > Subject: RE: [Bug 11235] Extensive use of string concatenation > throughout code base > > > > Noel, > > I've actually had all of this done for a few weeks now. My biggest > question has been how to post it in a way that it doesn't overload the > capacity of the list to vet the changes. It's a pretty wide-spread set > of changes. > > I guess I could start by submitting a couple of the more substantively > changed files (i.e. POP3Handler.java and SMTPHandler.java) for general > consideration), following up with a file or two a day. Or do we want to > try and digest it all in one lump? There are ~40 affected files. > > --Peter > > -----Original Message----- > From: Noel J. Bergman [mailto:[EMAIL PROTECTED]] > Sent: Sunday, July 28, 2002 12:51 PM > To: James Developers List > Subject: [Bug 11235] Extensive use of string concatenation throughout > code base > > re: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=11235 > > "This bug is really a performance/scalability/resources issue. The code > is > full (especially in the handlers) of string concatenation operators. > This > is > a very resource intensive operation when concatenating anything more > than 2 > string (i.e. "a" + "b" + "c" + "d") because of the temporary objects > created > and then discarded with each concatenation. It is very preferable to > use a > single StringBuffer instance to do this type of concatenation. This > eliminates the temporary object creation and hence improves performance. > This > is especially critical in the assorted handlers, where the use of the > concatenation operator is most prevalent, because these classes are > going to > be your bottlenecks for client interaction." > > I suppose that this would be a good project for people who want to help > out > without getting too deep into intricacies. Not the highest of > priorities, > but the changes should be clear and isolated. The patches should be > fairly > easy for people to vet, and the maintainers to commit. > > Peter, do you want to pick a single file, make the changes, and post it > as a > sample for what you think others should do? Not that this is more than > rote > conversion, but we might as use something as simple as this to start > trying > to adopt good habits. > > --- Noel > > > -- > To unsubscribe, e-mail: > <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: > <mailto:[EMAIL PROTECTED]> > > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
