Doron Cohen wrote:
Sounds good to me.
So it is IndexFileDeleter that can be used by applications to guarantee
"their" NFS-safe behavior, namely preventing premature files deletions.
Cool. We can probably sometimes write one such alternative, even in
contrib.
But, should enabling this way of extending IndexFileDeleter be part
of coming 2.1 release, or is it just a future wish?
Because I am not sure that current interfaces of/with IndexFileDeleter
are sufficient for this:
1) IndexWriter does not expose setDeleter().
It should probably somehow be in the constructor, because already at
that time files are deleted. (or found).
2) IndexReader allows setting the deleter, but only after the reader
is open. This is okay for its role in commit() (deleting).
But this might be too late for its new role (touching) - some writer
may be deciding to delete files in between.
There are more questions, but no point in getting to them unless this
extendibility is intended for 2.1. (?)
IndexFileDeleter definitely doesn't allow this today.
This idea (Doug's solution to change IndexWriter to optionally use
"commit only on close" and then allowing different IndexFileDeleter
policies as subclasses) is for the approach to LUCENE-710, which I'm
working on now. I'll add a summary of these discussions there.
I don't think we should hold up 2.1 for this. First, I'm not sure how
long it will take me to finish (I have a baby due in 23 days which is
making me very nervous!), and second I think we have alot of good stuff
already in the trunk to make up a solid 2.1 release.
I do think we should try to get LUCENE-565 into 2.1 (it is independent
of LUCENE-710)? I think it's a great step towards our "use
IndexWriter to make changes; use IndexReader for reading" goal and
would greatly reduce user confusion.
Of course this is really the decision of the Release Manager once we
get a volunteer :)
Mike
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
