: The original versions of that patches have been removed, but I was : originally concerned about overhead to the IndexWriter for people who : didn't use that delete functionallity (opening readers, keeping track : of the segment number for adds, etc).
do you still have those concerns with the version of NewIndexModifier on the trunk? ... skimming it i don't see any reason why it would add overhead to people using only the existing IndexWriter methods. : Also, I think the extension points are important since : NewIndexModifier does not (and probably never will be able to) do : everything people need. There can be very complex ways of identifying : documents to be deleted. It's also nice knowing when documents in ram : will be flushed to disk... one reason being that it correlates with : document visibility if you open a new reader. Which extension points are you refering to? ... the existing protected methods in IndexWriter and NewIndexModifier can of course be left as they are for other subclasses to override -- i'm just wondering if there is any benefit in IndexWriter and NewIndexModifier being seperate classes. -Hoss --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
