[ 
https://issues.apache.org/jira/browse/LUCENE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478161
 ] 

Hoss Man commented on LUCENE-814:
---------------------------------

Hmmm... if there are files that say "Generated By:JavaCC" which JavaCC does 
*not* generate, then perhaps we should remove that line from those files 
(making the regex a feasible solution)

It leaves me wondering: why do those files say they were generated by JavaCC if 
they aren't? ... were they only generated with JavaCC 3.0? are they no longer 
needed using 3.2?  do we depend on them even though they are (evidently) 
falling out of sync as QueryParser.jj evolves and QueryParser.java changes?

> javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant 
> replace'
> ---------------------------------------------------------------------------------
>
>                 Key: LUCENE-814
>                 URL: https://issues.apache.org/jira/browse/LUCENE-814
>             Project: Lucene - Java
>          Issue Type: Task
>          Components: Build
>         Environment: Windows, Cygwin
>            Reporter: Doron Cohen
>         Assigned To: Doron Cohen
>            Priority: Minor
>             Fix For: 2.2
>
>         Attachments: 814.javacc.fixcrlf.common-build.patch, 
> 814.javacc.fixcrlf.common-build.patch, 814.javacc.line.ends.patch, 
> LUCENE-814.txt, LUCENE-814.txt
>
>
> "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r  
> or \r\n instead of *Nix's \n). 
> I managed to get rid of those using    perl -p -e 's/(\r\n|\n|\r)/\n/g'
> Some useful info on line ending issues is in 
> http://en.wikipedia.org/wiki/Newline
> After wasting some time to get rid of those, I modified javacc-QueryParser 
> build.xml task to take care of that.
> So now QueryParser files created with "ant javacc" are fixed (if required) to 
> have \n as line ends.
> Should probably do that also for the other javacc targets: javacc-HTMLParser 
> and javacc-StandardAnalyzer(?)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to