[
https://issues.apache.org/jira/browse/LUCENE-814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Doron Cohen updated LUCENE-814:
-------------------------------
Attachment: 814.javacc.fixcrlf.common-build.patch
It was nice if javaCC had a 'native-eol' option. It doesn't, and the
modification time is used in attempt to imitate the availability of such an
option.
But I think you are right, there should be no harm in fixing crlf for all the
files containing the "generated" string - I'll go and commit it without the
date check.
For the javacc-clean comment - having it deleting all the files containing this
string will almost work - except for ParseException in standardTokenizer -
where a modified version is maintained. So we could modify javacc-clean to
delete all Java files containing that "generated" string, except for
ParseException in standardTokenizer. But if we want to do this, it rather be in
a separate issue. (Also, I noticed that contrib/surround has no javacc-clean,
and contrib/misc/o.a.l/queryParser/precedence has no javacc target.)
> javacc on Win32 (cygwin) creates wrong line endings - fix them with 'ant
> replace'
> ---------------------------------------------------------------------------------
>
> Key: LUCENE-814
> URL: https://issues.apache.org/jira/browse/LUCENE-814
> Project: Lucene - Java
> Issue Type: Task
> Components: Build
> Environment: Windows, Cygwin
> Reporter: Doron Cohen
> Assigned To: Doron Cohen
> Priority: Minor
> Fix For: 2.2
>
> Attachments: 814.javacc.fixcrlf.common-build.patch,
> 814.javacc.fixcrlf.common-build.patch, 814.javacc.fixcrlf.common-build.patch,
> 814.javacc.fixcrlf.common-build.patch, 814.javacc.line.ends.patch,
> LUCENE-814.txt, LUCENE-814.txt
>
>
> "ant javacc" in Windows/Cygwin generates files with wrong line endings (\r
> or \r\n instead of *Nix's \n).
> I managed to get rid of those using perl -p -e 's/(\r\n|\n|\r)/\n/g'
> Some useful info on line ending issues is in
> http://en.wikipedia.org/wiki/Newline
> After wasting some time to get rid of those, I modified javacc-QueryParser
> build.xml task to take care of that.
> So now QueryParser files created with "ant javacc" are fixed (if required) to
> have \n as line ends.
> Should probably do that also for the other javacc targets: javacc-HTMLParser
> and javacc-StandardAnalyzer(?)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
